你会为这样的 "微型" 代码段建立函数吗? - V2EX
V2EX = way to explore
V2EX 是一个关于分享和探索的地方
现在注册
已注册用户请  登录
请不要在回答技术问题时复制粘贴 AI 生成的内容
NerdHND
V2EX    程序员

你会为这样的 "微型" 代码段建立函数吗?

  •  
  •   NerdHND
    1216892614 280 天前 2192 次点击
    这是一个创建于 280 天前的主题,其中的信息可能已经有所发展或是发生改变。
    fn card_states_init( mut cmds: Commands, query_card: Query<(Entity, Option<&Children>), Added<Card>>, query_card_none: Query<(Entity, Option<&CardNone>)>, query_card_hover: Query<(Entity, Option<&CardHover>)>, query_card_action: Query<(Entity, Option<&CardAction>)>, ) { for (card, children) in query_card.iter() { if let None | Some((_, None)) = children .map(|c| c.iter().find_map(|c| query_card_none.get(*c).ok())) .flatten() { let child = cmds.spawn(CardNone).id(); cmds.entity(card).add_child(child); } if let None | Some((_, None)) = children .map(|c| c.iter().find_map(|c| query_card_hover.get(*c).ok())) .flatten() { let child = cmds.spawn(CardHover).id(); cmds.entity(card).add_child(child); } if let None | Some((_, None)) = children .map(|c| c.iter().find_map(|c| query_card_action.get(*c).ok())) .flatten() { let child = cmds.spawn(CardAction).id(); cmds.entity(card).add_child(child); } } } 

    我在写上面这行代码段的时候在思考, 我是否应该将这重复的四段代码修改为下面这样:

    fn card_states_init( mut cmds: Commands, query_card: Query<(Entity, Option<&Children>), Added<Card>>, query_card_none: Query<(Entity, Option<&CardNone>)>, query_card_hover: Query<(Entity, Option<&CardHover>)>, query_card_action: Query<(Entity, Option<&CardAction>)>, ) { for (card, children) in query_card.iter() { card_state_init(&mut cmds, children, card, &query_card_none); card_state_init(&mut cmds, children, card, &query_card_hover); card_state_init(&mut cmds, children, card, &query_card_action); } } fn card_state_init<T: Component>( cmds: &mut Commands, children: Option<&Children>, card: Entity, query_card_state: &Query<(Entity, Option<&T>)>, ) { if let None | Some((_, None)) = children .map(|c| c.iter().find_map(|c| query_card_state.get(*c).ok())) .flatten() { let child = cmds.spawn(CardNone).id(); cmds.entity(card).add_child(child); } } 

    这样修改乍一看确实简化了重复, 但是却引入了泛型, 如何后面这几个 state 在初始化的时候要单独处理就要么退回来重新用原本的方案再修改, 要么再写一种 init, 然后修改. 感觉不如一开始就不做这样的 "过早优化"

    8 条回复    2025-02-21 12:06:38 +08:00
    passive
        1
    passive  
       280 天前 via Android
    泛型是为了复用,不是为了 kpi
    hefish
        2
    hefish  
       280 天前
    优化得太高级了,太难读,所以我个人就不优化了。
    visper
        3
    visper  
       280 天前
    rust 啊,有时候类型复杂了看得头晕。如果晕的话就不优化得了。
    litchinn
        4
    litchinn  
       280 天前
    用宏呢
    R136a1
        5
    R136a1  
       280 天前
    我一般会采用折中的办法,把这个小函数放在原来的函数体里面
    NerdHND
        6
    NerdHND  
    OP
       280 天前
    @R136a1 函数体套函数体我只会用在递归的时候... 毕竟实际上是增加嵌套
    stiangao
        7
    stiangao  
       280 天前   1
    没必要,一眼能看懂的东西不需要抽象
    NerdHND
        8
    NerdHND  
    OP
       280 天前
    @stiangao 确实, 一句话说到本质了. 其他都是扯淡
    关于     帮助文档     自助推广系统     博客     API     FAQ     Solana     5169 人在线   最高记录 6679       Select Language
    创意工作者们的社区
    World is powered by solitude
    VERSION: 3.9.8.5 25ms UTC 07:37 PVG 15:37 LAX 23:37 JFK 02:37
    Do have faith in what you're doing.
    ubao msn snddm index pchome yahoo rakuten mypaper meadowduck bidyahoo youbao zxmzxm asda bnvcg cvbfg dfscv mmhjk xxddc yybgb zznbn ccubao uaitu acv GXCV ET GDG YH FG BCVB FJFH CBRE CBC GDG ET54 WRWR RWER WREW WRWER RWER SDG EW SF DSFSF fbbs ubao fhd dfg ewr dg df ewwr ewwr et ruyut utut dfg fgd gdfgt etg dfgt dfgd ert4 gd fgg wr 235 wer3 we vsdf sdf gdf ert xcv sdf rwer hfd dfg cvb rwf afb dfh jgh bmn lgh rty gfds cxv xcv xcs vdas fdf fgd cv sdf tert sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf sdf shasha9178 shasha9178 shasha9178 shasha9178 shasha9178 liflif2 liflif2 liflif2 liflif2 liflif2 liblib3 liblib3 liblib3 liblib3 liblib3 zhazha444 zhazha444 zhazha444 zhazha444 zhazha444 dende5 dende denden denden2 denden21 fenfen9 fenf619 fen619 fenfe9 fe619 sdf sdf sdf sdf sdf zhazh90 zhazh0 zhaa50 zha90 zh590 zho zhoz zhozh zhozho zhozho2 lislis lls95 lili95 lils5 liss9 sdf0ty987 sdft876 sdft9876 sdf09876 sd0t9876 sdf0ty98 sdf0976 sdf0ty986 sdf0ty96 sdf0t76 sdf0876 df0ty98 sf0t876 sd0ty76 sdy76 sdf76 sdf0t76 sdf0ty9 sdf0ty98 sdf0ty987 sdf0ty98 sdf6676 sdf876 sd876 sd876 sdf6 sdf6 sdf9876 sdf0t sdf06 sdf0ty9776 sdf0ty9776 sdf0ty76 sdf8876 sdf0t sd6 sdf06 s688876 sd688 sdf86